refactor dig

newrelic · Dec 20, 2024 · e077f46 · e077f46
1 parent 15896b9
commit e077f46
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/new_relic/agent/instrumentation/aws_sdk_firehose/instrumentation.rb b/lib/new_relic/agent/instrumentation/aws_sdk_firehose/instrumentation.rb
@@ -41,7 +41,8 @@ def instrument_method_with_new_relic(method_name, *args)
     end
 
     def get_segment_name(method_name, params)
-      return "#{FIREHOSE}/#{method_name}/#{params[:delivery_stream_name]}" if params&.dig(:delivery_stream_name)
+      stream_name = params&.dig(:delivery_stream_name)
+      return "#{FIREHOSE}/#{method_name}/#{stream_name}" if stream_name
 
       "#{FIREHOSE}/#{method_name}"
     rescue => e
@@ -55,9 +56,10 @@ def nr_account_id
     end
 
     def get_arn(params)
-      return params[:delivery_stream_arn] if params&.dig(:delivery_stream_arn)
+      return params.dig(:delivery_stream_arn) if params&.dig(:delivery_stream_arn)
 
-      NewRelic::Agent::Aws.create_arn(FIREHOSE.downcase, "deliverystream/#{params[:delivery_stream_name]}", config&.region, nr_account_id) if params[:delivery_stream_name]
+      stream_name = params&.dig(:delivery_stream_name)
+      NewRelic::Agent::Aws.create_arn(FIREHOSE.downcase, "deliverystream/#{stream_name}", config&.region, nr_account_id) if stream_name
     end
   end
 end