Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Streamline and rename chart #7

Merged
merged 1 commit into from
May 2, 2024
Merged

feat: Streamline and rename chart #7

merged 1 commit into from
May 2, 2024

Conversation

juanjjaramillo
Copy link
Contributor

Description

Streamline and rename chart to simplify customer onboarding

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@juanjjaramillo juanjjaramillo marked this pull request as ready for review May 1, 2024 19:03
@juanjjaramillo juanjjaramillo requested a review from a team May 1, 2024 19:03
Base automatically changed from juanjjaramillo/fix_helm_chart to main May 1, 2024 23:04
@juanjjaramillo
Copy link
Contributor Author

@ramkrishankumarN you should not approve a PR unless it is ready. I comment on Slack when PRs are ready for review

@juanjjaramillo juanjjaramillo force-pushed the juanjjaramillo/rename_chart branch from 76ef310 to 7626876 Compare May 1, 2024 23:09
@ramkrishankumarN
Copy link
Contributor

@ramkrishankumarN you should not approve a PR unless it is ready. I comment on Slack when PRs are ready for review

Thanks for the heads up. I will look at the changes again

ramkrishankumarN
ramkrishankumarN reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@ramkrishankumarN ramkrishankumarN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are renaming folder charts/newrelic-agent-operator to charts/k8s-agent-operator and changing the main Chart.yaml, right? Hard to comprehend these kinds of diffs in github.

@juanjjaramillo juanjjaramillo merged commit 8a453f6 into main May 2, 2024
4 checks passed
@juanjjaramillo juanjjaramillo deleted the juanjjaramillo/rename_chart branch May 2, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramkrishankumarN ramkrishankumarN ramkrishankumarN approved these changes

Assignees
No one assigned
Labels
Release/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanjjaramillo @ramkrishankumarN