-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include custom labels for NEW_RELIC_LABELS and also apply podlabel "newrelic-k8s-agents-operator-version" #155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 59.90% 60.31% +0.40%
==========================================
Files 22 22
Lines 1519 1532 +13
==========================================
+ Hits 910 924 +14
+ Misses 539 538 -1
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@ramkrishankumarN I'm not sure it should be a comma. I think agents are using ; as the delimiter ex: https://docs.newrelic.com/docs/apm/agents/java-agent/configuration/java-agent-configuration-config-file/#labels |
Description
https://new-relic.atlassian.net/browse/NR-311790
Given this user provided label, the final value of NEW_RELIC_LABELS will be "team:k8s,operator:auto-injection"
Type of change
Checklist: