Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include custom labels for NEW_RELIC_LABELS and also apply podlabel "newrelic-k8s-agents-operator-version" #155

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

ramkrishankumarN
Copy link
Contributor

Description

https://new-relic.atlassian.net/browse/NR-311790

        env:
         - name: NEW_RELIC_LABELS
           value: "team:k8s"

Given this user provided label, the final value of NEW_RELIC_LABELS will be "team:k8s,operator:auto-injection"

  1. Add pod label "k8s_agents_operator_version:{appVersionNo}" to every mutated pod.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@ramkrishankumarN ramkrishankumarN requested a review from a team as a code owner November 15, 2024 20:19
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.31%. Comparing base (5c8db05) to head (064307a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   59.90%   60.31%   +0.40%     
==========================================
  Files          22       22              
  Lines        1519     1532      +13     
==========================================
+ Hits          910      924      +14     
+ Misses        539      538       -1     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@elucus
Copy link

elucus commented Nov 15, 2024

@ramkrishankumarN I'm not sure it should be a comma. I think agents are using ; as the delimiter ex: https://docs.newrelic.com/docs/apm/agents/java-agent/configuration/java-agent-configuration-config-file/#labels

danielstokes
danielstokes previously approved these changes Nov 18, 2024
@ramkrishankumarN ramkrishankumarN changed the title feat: Include custom labels for NEW_RELIC_LABELS and also apply podlabel "k8s_agents_operator_version" feat: Include custom labels for NEW_RELIC_LABELS and also apply podlabel "newrelic-k8s-agents-operator-version" Nov 19, 2024
@ramkrishankumarN ramkrishankumarN merged commit 7d5f05c into main Nov 20, 2024
20 checks passed
@ramkrishankumarN ramkrishankumarN deleted the ramk/unify-add-labels branch November 20, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants