Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create Dockerfile #14

Merged
merged 1 commit into from
May 7, 2024
Merged

feat: Create Dockerfile #14

merged 1 commit into from
May 7, 2024

Conversation

juanjjaramillo
Copy link
Contributor

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@juanjjaramillo juanjjaramillo marked this pull request as ready for review May 6, 2024 23:06
@juanjjaramillo juanjjaramillo requested a review from a team May 6, 2024 23:06
@juanjjaramillo juanjjaramillo force-pushed the juanjjaramillo/dockerfile branch from d0d37d2 to ad8fff8 Compare May 6, 2024 23:25
@juanjjaramillo juanjjaramillo merged commit e5f96c4 into main May 7, 2024
4 checks passed
@juanjjaramillo juanjjaramillo deleted the juanjjaramillo/dockerfile branch May 7, 2024 02:44
paologallinaharbur pushed a commit to paologallinaharbur/k8s-agents-operator that referenced this pull request Sep 6, 2024
@rogercoll
feat: add basic command executor (newrelic#14)
00eac05 
* feat: add single binary command executor implementation

* refactor: move singlebinary to processrunner

* feat: consume command self to use start or stop

* feat: add command using executor and handler

* feat: prevent exposing child to process runner api

* fix: windows tests

* ci: disable miri for integration tests

See: rust-lang/miri#2057

* fix: remove unwraps in favor of ok_or

* refactor: move wrapper into processrunner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbudziwojskiNR dbudziwojskiNR dbudziwojskiNR approved these changes

Assignees
No one assigned
Labels
Release/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanjjaramillo @dbudziwojskiNR