Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws.requestId to Log Message if the lambda_request_id is found #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

david-a-jetter
Copy link

This copies the value that is set in aws.lambda_request_id to aws.requestId on the log message dictionary that is ultimately submitted to the New Relic Logs API.

The reason for this is to support a use case leveraging Insights dashboards that combine data from AwsLambdaInvocation and Log NRQL queries along with the Filter New Relic One dashboards by facets. The idea being to:

  1. Build a query / chart that fetches matching Invocations
  2. Leverage the filtering feature to filter the dashboard
  3. Fetch logs relevant to the specific invocation that is selected

The way the filtering feature is built is it seems to leverage the exact field name from the source chart that is being used as a filter. In the case of AwsLambdaInvocation, this is named aws.requestId. With current behavior, this will effectively filter out all logs, since this field is not populated in the Log entity.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ umaannamalai
❌ djetter-py


djetter-py seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@nashahzad nashahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MattWhelan MattWhelan requested a review from bmcfeely January 15, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants