Merge pull request #1638 from newjersey/feature-add-login-redirect-logic

Feature add login redirect logic
newjersey · Feb 8, 2022 · cb97890 · cb97890
2 parents 79f1882 + f009fa7
commit cb97890
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/web/src/pages/roadmap.tsx b/web/src/pages/roadmap.tsx
@@ -44,7 +44,10 @@ const RoadmapPage = (props: Props): ReactElement => {
 
   useEffect(() => {
     if (!router.isReady) return;
-    if (router.query.error === "true" && userData?.profileData.hasExistingBusiness) {
+    if (
+      (router.query.error === "true" || (router.query?.code && router.query?.state)) &&
+      userData?.profileData.hasExistingBusiness
+    ) {
       router.replace("/dashboard");
     }
 

diff --git a/web/test/pages/index.test.tsx b/web/test/pages/index.test.tsx
@@ -55,10 +55,10 @@ describe("HomePage", () => {
     expect(mockPush).toHaveBeenCalledWith("/onboarding");
   });
 
-  it("redirects to onboarding page when it is unknown if user has completed onboarding flow or not", () => {
+  it("redirects to roadmap page when it is unknown if user has completed onboarding flow or not", () => {
     setMockUserDataResponse({ error: "NO_DATA", userData: undefined });
     render(withAuth(<Home />, { user: generateUser({}) }));
-    expect(mockPush).toHaveBeenCalledWith("/roadmap");
+    expect(mockPush).toHaveBeenCalledWith("/roadmap?error=true");
   });
   it("opens the modal with signUp = true in the querystring", () => {
     useMockRouter({ isReady: true, query: { signUp: "true" } });