Update and re-fire W Edition warning #2185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can think of two possibilities about what the "W Edition" upload of New XKit will do if we release 7.10.0:
a) Nothing. This will mean that users with the "W Edition" installed will never receive future extension updates. We should update the warning message to include this information, keeping the warning about it being in violation of store policies, and change the storage key so that users who have dismissed it a long time ago will see it again. We should merge this only once 7.10.0 is out (as it would be inaccurate otherwise; currently "W Edition" does receive extension updates).
b) Update itself when New XKit releases, possibly quickly but possibly on any amount of delay. This will mean that users with the "W Edition" installed may or may not receive future extension updates in a timely fashion. We should update the warning message to include this information and change the storage key so that users who have dismissed it a long time ago will see it again. We should ideally merge this before 7.10 is released, to make sure it makes it in to a hypothetical W edition 7.10.
This PR splits the warning message copy into variants for pre- and post-7.10.0 and updates them accordingly, and bumps the storage key. As per those points, it makes sense to merge this into 7.10.0 right before it's released (to minimize merge conflicts) and then to wait on merging it in to 7.9.2 until that release passes review (if it does, obviously) and is published.