Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.9.2: Fix XKit Patches on any future versions #2166

Merged

Conversation

marcustyphoon
Copy link

@marcustyphoon marcustyphoon commented Nov 24, 2024

As in #2165, this improves the XKit Patches run_order logic a bit, such that versions not contained in the run_order array simply have no patches applied and it thus does not need to be updated for future releases. It also fixes the crash if one adds an entry to run_order without adding a corresponding (potentially empty) entry to patches that I triggered earlier, and pulls a whitespace change from the main branch.

@marcustyphoon marcustyphoon changed the title v7.9.2: Fix XKit Patches on future versions v7.9.2: Fix XKit Patches on any future versions Nov 24, 2024
Copy link

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM!

@marcustyphoon marcustyphoon merged commit 795f93e into new-xkit:7.9.2 Dec 1, 2024
1 check passed
@marcustyphoon marcustyphoon deleted the 7.9.2-future-patches-fix branch December 1, 2024 21:16
marcustyphoon added a commit to marcustyphoon/XKit that referenced this pull request Dec 1, 2024
marcustyphoon added a commit to marcustyphoon/XKit that referenced this pull request Dec 1, 2024
marcustyphoon added a commit to marcustyphoon/XKit that referenced this pull request Dec 1, 2024
marcustyphoon added a commit to marcustyphoon/XKit that referenced this pull request Dec 2, 2024
This was referenced Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants