forked from Tylian/XKit
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.9.2: Fix XKit Patches on any future versions #2166
Merged
marcustyphoon
merged 6 commits into
new-xkit:7.9.2
from
marcustyphoon:7.9.2-future-patches-fix
Dec 1, 2024
Merged
v7.9.2: Fix XKit Patches on any future versions #2166
marcustyphoon
merged 6 commits into
new-xkit:7.9.2
from
marcustyphoon:7.9.2-future-patches-fix
Dec 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
changed the title
v7.9.2: Fix XKit Patches on future versions
v7.9.2: Fix XKit Patches on any future versions
Nov 24, 2024
hobinjk
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and LGTM!
marcustyphoon
added a commit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Dec 1, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #2165, this improves the XKit Patches
run_order
logic a bit, such that versions not contained in therun_order
array simply have no patches applied and it thus does not need to be updated for future releases. It also fixes the crash if one adds an entry torun_order
without adding a corresponding (potentially empty) entry topatches
that I triggered earlier, and pulls a whitespace change from the main branch.