Old Blue: Add generated color overrides for new theme variables #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobinjk
approved these changes
Nov 22, 2024
|
Honestly, I think it was somewhat out of date shortly after it was created; Tumblr has if I recall correctly been making small tweaks to these colors over time. I haven't completely decided if shipping a mostly-correct palette (and, presumably, updating it over time and/or coming up with a way to fully automate it) is better or worse than delaying until I'm more sure. I mean... "better" seems to have a lot of points in favor in this case; the way it's broken now feels fairly arbitrary so there's not a lot of downside? Eh. |
This reverts commit 84f29fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Tumblr design system has a new (huge) set of theme color variables, which Old Blue doesn't currently override. This affects elements such as the create button and notification badges and some new pages like community settings.
This copies the color overrides generated in AprilSylph/Palettes-for-Tumblr#203 into Old Blue; see that PR for additional details.