Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (including web-ext) #2145

Closed

Conversation

marcustyphoon
Copy link

Updates npm dependencies and github actions dependencies, clearing up all security warnings.

Requires at least node 16 (for web-ext to run); it actually has dependencies that request node 18 but I don't see any problems running scripts on 16.

Warning: this updates web-ext to v8, which per https://extensionworkshop.com/documentation/develop/web-ext-command-reference/ requires some command changes. I did not test web-ext sign. #2142 is a PR without this bump.

Also, while I did run gulp server (in node 14-20), I never set up local development and so I have no idea if it actually works with this PR. I have no clue if anyone else has one set up, frankly, but ideally one should, you know, test that at all.

@marcustyphoon marcustyphoon force-pushed the update-dependencies-2 branch from 958aded to a242690 Compare August 15, 2024 04:32
@marcustyphoon marcustyphoon marked this pull request as draft September 9, 2024 09:01
@marcustyphoon
Copy link
Author

marcustyphoon commented Sep 9, 2024

  • --approval-timeout=0

@marcustyphoon
Copy link
Author

Closing because we may remove gulp; this would merge conflict all over if we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant