Blacklist: Implement blacklist to native filtering export (and fix) #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: April Sylph <[email protected]>
this thing is a catastrophe
nightpool
previously requested changes
Nov 25, 2022
Co-authored-by: nightpool <[email protected]>
Co-Authored-By: nightpool <[email protected]>
Update blacklist.js Co-Authored-By: nightpool <[email protected]>
Co-Authored-By: nightpool <[email protected]>
Co-Authored-By: nightpool <[email protected]>
hobinjk
approved these changes
Dec 11, 2024
hobinjk
dismissed
nightpool’s stale review
Comments were addressed, also two years have passed and this is urgent-ish now
|
Looking at it now, I actually propose removing the bit Nightpool highlighted, as it'll probably cause confusion with XKit Rewritten's identical feature particularly when New XKit is removed. Agree/disagree? |
|
That's a fair point, cosigned |
hobinjk
approved these changes
Dec 11, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit
that referenced
this pull request
Dec 11, 2024
…ew-xkit#2104) Co-authored-by: April Sylph <[email protected]> Co-authored-by: nightpool <[email protected]>
marcustyphoon
added a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: April Sylph <[email protected]> Co-authored-by: nightpool <[email protected]> fix) (#2104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an interactive UI for exporting the user's blacklisted words into Tumblr's native tag filtering and post content filtering lists. The user is given the opportunity to customize their terms, hopefully helping them account for the functional differences between the Tumblr filtering and Blacklist's filtering, like the lack of asterisk wildcards.
I ported thedomandapiFetchhelper functions from XKit Rewritten for ease of development. (Of course they don't belong inline like this, given the premise that this is an actively developed project and all.)Also, this fixes that destroy() had a random 0.5 second delay, which would make it run after it restarted whenever you changed a setting, which would unhide every correctly hidden post on the screen, which... is... interesting.