PostBlock: Change button icon #2054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
previously requested changes
Apr 20, 2021
|
I have one concern... while this icon does better fit the design language of the post footer, and SVGs are very nice, this "no entry" symbol is already used in XKit as Blacklist's control panel icon:
I don't think it's a great idea to introduce a source of potential confusion like this. |
|
@AprilSylph that's a really good point, that could introduce some ambiguity. Here are two more design styles I tried, do either of these look good?
|
|
I just finished a third possible style as well! Personally, this one is my favorite so far.
|
This was referenced Jun 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a new button icon for PostBlock that (imo) fits in with the design style of the default tumblr icons better. Let me know if there are any changes you need. It's also an SVG unlike the old icon, which should allow it to scale better without pixelation. Thanks!
Here's what it looks like on a post:
