Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitelist not being sent to client #469

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Oct 24, 2023

About the PR

I made an oopsie and forgot the bit of code that sends clients their whitelist status, meaning they'd only be aware of their whitelist while connected, for the duration of that connection.

Closes #465

Changelog
🆑

  • fix: Whitelists should now work properly again.

@dvir001
Copy link
Contributor

dvir001 commented Oct 24, 2023

Nice, thanks for all the work.

@DebugOk DebugOk marked this pull request as ready for review October 24, 2023 17:11
@DebugOk
Copy link
Contributor Author

DebugOk commented Oct 24, 2023

Should be good now. I'll still have to rewrite how it sends whitelist at some point, but for now this'll work

@DebugOk
Copy link
Contributor Author

DebugOk commented Oct 24, 2023

Huh? Thats a test failure I've never seen before

@DebugOk DebugOk closed this Oct 24, 2023
@DebugOk DebugOk reopened this Oct 24, 2023
@DebugOk DebugOk marked this pull request as draft October 24, 2023 17:37
@DebugOk DebugOk marked this pull request as ready for review October 24, 2023 18:06
@Cheackraze Cheackraze merged commit 5f917f4 into new-frontiers-14:master Oct 24, 2023
8 of 9 checks passed
FrontierATC added a commit that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients aren't made aware of their whitelist status
3 participants