Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloth chairs to not claim your soul #2678

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 11, 2025

About the PR

Change to how you make them to a single step, so we cannot claim souls anymore.

Why / Balance

Chairs should not be eating humans

How to test

Build a chair, sit on it, screwdriver it.

Media

N/A

Requirements

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 11, 2025
Copy link
Contributor

@GreaseMonk GreaseMonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god bless

@dvir001 dvir001 changed the title FIx cloth chairs to not claim your soul Fix cloth chairs to not claim your soul Jan 11, 2025
@whatston3
Copy link
Contributor

Buckled condition working at whatston3:2025-01-11-ClothChair-suggestions

diff vs. master

Works alright in tests - if something's sitting on a chair, you'll get a do-after and then it'll place the carpet on the floor - not ideal, but nothing gets sent to the garbage dimension.

@whatston3
Copy link
Contributor

For what it's worth, I like having the construction graph the same as the fancy tables if only for consistency.

@arimah
Copy link
Contributor

arimah commented Jan 11, 2025

For what it's worth, I like having the construction graph the same as the fancy tables if only for consistency.

I second this. Also because it makes it easier to upgrade wooden chairs in situ, that is, without needing to deconstruct them first. :>

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 11, 2025

Buckled condition working at whatston3:2025-01-11-ClothChair-suggestions

diff vs. master

Works alright in tests - if something's sitting on a chair, you'll get a do-after and then it'll place the carpet on the floor - not ideal, but nothing gets sent to the garbage dimension.

Go for it

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine - give it another look when you can but think this is fine.

@Cheackraze Cheackraze merged commit 753bad3 into new-frontiers-14:master Jan 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants