Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ghosts worthless #2651

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

arimah
Copy link
Contributor

@arimah arimah commented Jan 3, 2025

About the PR

Forces ghosts to appraise at 0 spesos, by subscribing to PriceCalculationEvent and setting the price to zero.

Why / Balance

If an aghost happens to be over a ship while it's being sold, the value of whatever the ghost is carrying will be added to the ship's sell value. In most cases, aghosts are only worth 1k-2k. We've recently had a situation where an aghost was carrying many millions of spesos, which required administrative intervention. Bit of an oopsie. This ensures aghosts are never included in the final price no matter what.

Additionally, some people like to appraise their ships by loading and initialising the grid, then running appraisegrid because some old guide somewhere says to do that. If you happened to be on grid, the value of your aghost would be counted too! Oopsies.

How to test

  1. Buy a ship. Leave the ID in the console.
  2. Aghost.
  3. Move over to the ship, then open the shipyard console to see what it appraises at.
  4. Spawn yourself a large number of spesos or some valuable items. Reopen the shipyard console, see no change in appraisal price.
  5. Join the server on a second account, sell the ship with the aghost still on it. Don't become a millionaire.

Media

N/A

Requirements

Breaking changes

Noperoonies.

Changelog
N/A

@github-actions github-actions bot added the C# label Jan 3, 2025
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@dvir001
Copy link
Contributor

dvir001 commented Jan 3, 2025

Thanks for the PR, all game admins are now worthless.

@dvir001 dvir001 merged commit 0f1e2da into new-frontiers-14:master Jan 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants