Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certain donuts being unable to fit inside a donut box #2649

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

KieueCaprie
Copy link
Contributor

About the PR

Blue-Pumpkin jelly donuts, Bungo jelly donuts, Apple jelly donuts, and meat donuts were unable to fit inside a donut box due to being erroneously marked as non-donuts due to tags being overwritten. This PR fixes this by defining the Donut tag WITH the fruit/meat tag.

Why / Balance

Because it makes no sense that a donut made of fruit or meat cannot fit inside a standard issue donut box.

How to test

  1. Spawn a donut box.
  2. Spawn a blue-pumpkin jelly-donut, bungo jelly-donut, apple jelly-donut, and meat donut.
  3. Place each donut inside the donut box one-by-one.
  4. mmm donuts.

Media

image

Requirements

Changelog
🆑

  • fix: Fixed certain jelly-filled donuts, and a particularly meaty one, being unable to fit inside a donut box.

@KieueCaprie KieueCaprie marked this pull request as ready for review January 3, 2025 01:11
@dvir001 dvir001 self-requested a review January 3, 2025 01:12
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 3, 2025
@dvir001 dvir001 merged commit 1238647 into new-frontiers-14:master Jan 3, 2025
25 checks passed
FrontierATC added a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants