Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ice sink #2635

Merged
merged 8 commits into from
Jan 5, 2025
Merged

Adds ice sink #2635

merged 8 commits into from
Jan 5, 2025

Conversation

dustylens
Copy link
Contributor

About the PR

This PR adds a new sink type, an ice box, which slowly refills with ice for use in cooking environments.

Why / Balance

Ice is a somewhat finite resource at present, given the challenges in making it. As it has virtually no use that I could discern outside of limited culinary uses (time for a smoothie and ice cream PR) adding a mappable ice sink for bars and restaurants seemed like a good solution.

How to test

Place sink.
Take ice if full. Ensure it refills with ice and not, you know, coffee.
Check orientation sprites. Check drain sprites in all orientations. Try to not get a brain freeze.

Media

ss+(2024-12-30+at+11 16 33)

Requirements

Breaking changes

Changelog

🆑

  • add: mappable ice box for bars and restaurants!

Copy link
Contributor

github-actions bot commented Dec 30, 2024

RSI Diff Bot; head commit 8605d37 merging into 78a4933
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Furniture/icebox.rsi

State Old New Status
icebox Added
icebox_fill-1 Added

Edit: diff updated after 8605d37

@dvir001 dvir001 requested a review from whatston3 December 30, 2024 19:24
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 30, 2024
@chrome-cirrus
Copy link
Contributor

Okay but is accidentally breaking a glass in the thing and having to dump it all and thoroughly clean it then agonizingly wait for more ice to drop during rush implemented?

@dustylens
Copy link
Contributor Author

Okay but is accidentally breaking a glass in the thing and having to dump it all and thoroughly clean it then agonizingly wait for more ice to drop during rush implemented?

Absolutely. As is getting fired on the spot for being caught scooping ice with a glass.

@chrome-cirrus
Copy link
Contributor

Okay but is accidentally breaking a glass in the thing and having to dump it all and thoroughly clean it then agonizingly wait for more ice to drop during rush implemented?

Absolutely. As is getting fired on the spot for being caught scooping ice with a glass.

This is the attention to detail that makes games like this really shine.

@dustylens
Copy link
Contributor Author

dustylens commented Jan 5, 2025

Added a new empty ice bucket for the service techfab as per request.

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sink me up inside

@dustylens
Copy link
Contributor Author

I sink you went too far.

@dvir001 dvir001 merged commit 027c1a9 into new-frontiers-14:master Jan 5, 2025
14 checks passed
FrontierATC added a commit that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants