Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the detective's spawn clothing options #2621

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RangerXVII
Copy link

@RangerXVII RangerXVII commented Dec 27, 2024

About the PR

Added a grey fedora, detective noir jumpsuit and jumpskirt to the detective's loadout.

Why / Balance

Everything I added was already available in the DetDrobe, I just made it so that a detective does not need to go to their office for a grey fedora or noir jumpsuit.

How to test

  1. Open the detective loadout page.
  2. Note the new items in the head and jumpsuit categories.
  3. Choose any of them.
  4. Spawn as detective and note that you spawn with what you chose.

Requirements

Changelog

🆑

  • tweak: Added new clothes to the detective's loadout.

@whatston3
Copy link
Contributor

Looks fine, seems reasonable, might change the names while we're here if that's fine by you.

@whatston3
Copy link
Contributor

Suggestions here: whatston3:nfsd-detective-clothing-options-change-suggestions

More consistent with other loadouts, pardon the mess - detectives will probably lose their outfits given the ID changes, but what better time to pick your outfit than with entirely new wardrobe options.

@RangerXVII
Copy link
Author

yeah those names do make a lot more sense.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants