Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Goblin to list of accents accentless disables #2598

Closed

Conversation

Alkheemist
Copy link
Contributor

About the PR

Added goblin accent to list of accents accentless affects in speech.yml

Why / Balance

So that goblins can be intelligible (if they want to)

How to test

Create a goblin, pick accentless as a trait, say something.

Media

dotnet_22_08-52-21

Requirements

Breaking changes

N/A

Changelog

🆑

  • fix: Accentless now works on goblins.

@dvir001
Copy link
Contributor

dvir001 commented Dec 21, 2024

For the record this was intended to not be there.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 21, 2024
@Alkheemist
Copy link
Contributor Author

the other thing is that accentless costs 2 trait points, which means you can't replace a goblin accent with any other accent.
I guess forcing goblins to have an accent adds to the flavour of the species (consistency over radio)

@ErhardSteinhauer
Copy link
Contributor

It was indeed intended for goblins to have forced accent.

@dvir001
Copy link
Contributor

dvir001 commented Jan 4, 2025

Closing this for now, not a final call on this but unless there is more demand this wont change for now.

@dvir001 dvir001 closed this Jan 4, 2025
@Bonaout
Copy link
Contributor

Bonaout commented Jan 4, 2025

How much more demand do we need ? I would love to see this change be made !

@Alkheemist
Copy link
Contributor Author

https://discord.com/channels/1123826877245694004/1242633089553797150/1325205692990357535
There is a poll now, if anyone feels strongly about this.

If it doesn't go through though, it should probably be made clear that accentless doesn't work on goblins. Some people thought this was a bug/oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants