Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTK Rework #2521

Merged
merged 32 commits into from
Dec 24, 2024
Merged

PTK Rework #2521

merged 32 commits into from
Dec 24, 2024

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Dec 6, 2024

About the PR

Largely supercedes #2436, created from suggestions mentioned in comments there.

Gives the PTK a niche purpose: destroying hard rocks. Walls on asteroids are no longer obstacles to avoid PTK use, but sources of denser ore deposits. These "supercompacted rock" walls require specialized equipment to destroy (PTK bolts, diamond drills, and/or holopickaxes). The reflection from walls has been removed.

PTKs in particular now overpenetrate softer rocks, destroying any ore gathered from them. This requires you to either:
A. be careful with PTK shots, using it to surgically remove higher value ore (that you know about through dwarven intuition or mining analyzers).
B. clear the asteroid in multiple passes, destroying the softer rocks before using the PTK to remove the harder targets
C. use a diamond drill or holopickaxe (generally requiring salvagers to purchase or otherwise source these) and clear the asteroid in one pass

Why / Balance

Flying around an asteroid with zero threat, blasting rocks away is not good design, and the reflect chance was a bad bandage fix.

How to test

  1. Use the PTK to mine on an asteroid. Softer rocks should be destroyed leaving nothing, harder rocks (walls) will be destroyed leaving their ore.
  2. Use a holopickaxe and diamond drill to mine an asteroid. All rock types should be destroyed and leave their ores.
  3. Use a glaive, pickaxe, any other mining tool you can think of to mine. Soft rock types should be destroyed, and harder rock types should be unaffected.

Media

image

Requirements

Breaking changes

Changelog

🆑

  • tweak: Walls on asteroids can now contain ore denser than regular rocks and require diamond drills, a holopickaxe, or a PTK to mine.
  • tweak: PTK bolts destroy ore in softer rock, but "walls" no longer reflect shots.

@whatston3
Copy link
Contributor Author

Going to move this to draft - branch is feature complete, but the loot tables might benefit from a rebalance, and ideally there's a way to specify the way asteroids spawn without needing so much configuration.

@whatston3 whatston3 marked this pull request as draft December 6, 2024 19:31
@dvir001 dvir001 self-requested a review December 6, 2024 19:49
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 6, 2024
@arimah
Copy link
Contributor

arimah commented Dec 6, 2024

Conceptually, I really like the idea of requiring more powerful equipment to do the job that a person cannot reasonably with a (normal) pickaxe or crusher, and it gives us a way to clear those pesky wall things, with a nice little reward for doing so.

@GreaseMonk
Copy link
Contributor

GreaseMonk commented Dec 6, 2024

Pros:

  • PTK mines hard rocks

Cons:

  • PTK no longer mines soft rocks, losing its primary use.
  • Diamond drill does the same without setup and travel time to collect
  • PTK requires time to setup and time to go to ship to shoot and back to asteroid to collect
  • Can probably still be used to shoot any POI to smithereens for looting which happens.

I hope this is constructive enough, my vote is to remove PTK altogether, because there is no point in keeping it or making alternativee gameplay that invalidates the main use

@Eponymic-sys
Copy link

Eponymic-sys commented Dec 8, 2024

Generally I like this, I'm not sure it's enough to actually make the PTK good, but it gives it a niche and adds a trade off between visiting a science ship for a drill or just doing it yourself.

I do wish there were an easier way to split the difference, PTK gives lower ore on softer, but looking at your changes that'd be a lot of work.

This is a good change even if the PTK gets removed.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Dec 8, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Dec 8, 2024
@DmitriTheDemon
Copy link
Contributor

* Can probably still be used to shoot any POI to smithereens for looting which happens.

As I understand it this change won't revert that issue which was addressed by lowering the PTK damage.

@whatston3 whatston3 marked this pull request as ready for review December 13, 2024 17:54
@github-actions github-actions bot added the Map-Dungeon Map - Dungeon label Dec 20, 2024
@dvir001 dvir001 mentioned this pull request Dec 21, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pew Pew Pew

@github-actions github-actions bot added the Map-Bluespace Map - Bluespace Event label Dec 23, 2024
@whatston3
Copy link
Contributor Author

image

Thanks in part to Dvir's hard work, we now have rare clusters of high value material spawning on asteroids.

image

The cave's diamonds have also been swapped over to these.

@dvir001 dvir001 merged commit 506679f into new-frontiers-14:master Dec 24, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-Bluespace Map - Bluespace Event Map-Dungeon Map - Dungeon Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants