EMP Blast #2262
Merged
EMP Blast #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Cheackraze
reviewed
Oct 16, 2024
| /// Can be overridden by <see cref="Robust.Shared.Spawners.TimedDespawnComponent"/>. | ||
| /// </summary> | ||
| [DataField, AutoNetworkedField] | ||
| public float VisualDuration = 2f; |
There was a problem hiding this comment.
this feels really long to me. for a 'blast', the effect lasts a bit too long and makes the screen hard to see if there are more than 1 happening at once.
There was a problem hiding this comment.
Can try it as 1 sec, the animation speed is fully under control.
|
do we want to show this blast when graphics is set to low ? just wondering |
Its fine |
|
I fixed the code to allow it to be shown with infinite range only when the EMP is 25+ (M_EMP) so you can see EMP coming from outside your PVS range. |
FrontierATC
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Edited the EMP animation to have a nice look.
Why / Balance
It looked bad
How to test
Spawn emp tools and have fun
Media
Too large
https://discord.com/channels/1123826877245694004/1123826879892299783/1296215896402165821
Requirements
Breaking changes
N/A
Changelog
🆑