Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuelVend Update #2255

Merged
merged 9 commits into from
Oct 16, 2024
Merged

FuelVend Update #2255

merged 9 commits into from
Oct 16, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Oct 16, 2024

About the PR

Fix stack issues for #2209
Made the fuel vend offer fuel pack refill to allow fixing the pricing to not be broken on sheets.

Media

Requirements

Breaking changes

A bit of an oversight on the code but the fuel pack can still be converted back to normal plasma and uranium using eject on generators but it is what it is.

Changelog

@dvir001 dvir001 requested a review from whatston3 October 16, 2024 00:53
@github-actions github-actions bot added No C# YML Status: Needs Review This PR is awaiting reviews labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

RSI Diff Bot; head commit 84e7609 merging into 201da20
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Specific/Fuel/fuelgrade_material.rsi

State Old New Status
bananium Added
plasma Added
uranium Added

Edit: diff updated after 84e7609

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generators now (optionally) eject fuel-grade materials - all existing solid fuel generators now eject fuel-grade materials, so no refining your fuel-grade plasma into high quality mined plasma at the push of a button.

The changes to get this working were fairly small, and seem to work well in testing.

I've left a set of sprites for fuel-grade plasma, uranium and bananium, largely based on the existing stacks, they look a bit dingy, and it should be easy to tell at a glance which are fuel-grade.

image

@dvir001 dvir001 merged commit 823f395 into new-frontiers-14:master Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants