Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagle, Phoenix (Guidebook Entry) #2218

Merged

Conversation

Mygnol
Copy link
Contributor

@Mygnol Mygnol commented Oct 13, 2024

About the PR

Adds guidebook entry and schematic for the Honker and Sparrow.

Why / Balance

Greyed out manual button bad.
Entry submissions will continue until guidebook improves.

How to test

  • Go to shipyard
  • Find eagle and phoenix
  • Manual button now has accompanying entries

Media

image
image

Requirements

Breaking changes

If I say it won't, it will.

Changelog

Trivial feature, no changelog.

@github-actions github-actions bot added Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle No C# Sprites YML FTL labels Oct 13, 2024
Copy link
Contributor

github-actions bot commented Oct 13, 2024

RSI Diff Bot; head commit f0981e4 merging into b3635ef
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Guidebook/shuttle_maps/128x96.rsi

State Old New Status
eagle Added
phoenix Added

Edit: diff updated after f0981e4

@Mygnol
Copy link
Contributor Author

Mygnol commented Oct 13, 2024

Leaving as draft due to comment by @ErhardSteinhauer on #2150 and #2128.
Do let me know if I should hold this till the new guidelines are out, or omit the checklist section, or push only the sprites.

@dvir001 dvir001 changed the title Guidebook Entry: Eagle, Phoenix Eagle, Phoenix (Guidebook Entry) Oct 18, 2024
@GreaseMonk
Copy link
Contributor

@Mygnol if it is ready for review just set it as ready for review

@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Oct 19, 2024
@ErhardSteinhauer
Copy link
Contributor

Can merge it since it's already done, but regarding making new PRs - still might wanna wait 'til maptainers come up with new standard for guidebook.

@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review October 19, 2024 15:55
@Mygnol
Copy link
Contributor Author

Mygnol commented Oct 19, 2024

It's already done, feel free to merge it. Was leaving it as draft for courtesy in case the standard was coming out soon.

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, prolly should merge it after #2271

@ErhardSteinhauer ErhardSteinhauer merged commit c85045c into new-frontiers-14:master Oct 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation FTL Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews Sprites YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants