Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interceptor (Update Shuttle) #2199

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

chrome-cirrus
Copy link
Contributor

About the PR

Updates the NSF Interceptor to modernize things a bit:

  • Replace tiny fans with directional fans
  • Replace loose plasma sheet fuel with a pre-filled locker
  • Add firelocks to interior doors
  • Remove some duplicate wiring elements
  • Replaced some fixed wall posters with random poster spawners
  • Replaced wall recharger with a tabletop model

Why / Balance

Compliance with the Tiny Fan Reduction Act of 2024, general modernization.

How to test

Spawn one in and take it for a spin.

Media

docked
mapping
nodevis

Requirements

Breaking changes

None

Changelog

🆑

  • tweak Update the NSF Interceptor

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Oct 12, 2024
@chrome-cirrus
Copy link
Contributor Author

chrome-cirrus commented Oct 12, 2024

Two things:

  • Still has a single can atmos setup. I like to change these to two can ones, but opinions vary and it would require moving a bunch of crap in the cockpit, so I left it alone.
  • I noticed some custom labels on buttons for the shutters. Do we want to rip out existing examples of that, or is it just a new ship guideline to not do them?

@chrome-cirrus
Copy link
Contributor Author

Found a duplicate scrubber I missed on earlier passes. Also rerouted the waste vent for a cleaner look.

atmostweak

@Tych0theSynth
Copy link
Contributor

Two things:

* Still has a single can atmos setup. I like to change these to two can ones, but opinions vary and it would require moving a bunch of crap in the cockpit, so I left it alone.

* I noticed some custom labels on buttons for the shutters. Do we want to rip out existing examples of that, or is it just a new ship guideline to not do them?

I was the person who reworked this ship a while back, and it was done before Vox happened. Thank you for fixing some of my mapping errors! Yes the button labels can be removed as they are no longer allowed because of translation issues.
I used set posters to give more of a specific detective theme, but random ones are fine. They're just posters after all, but I would keep them legit as these are NT vessels!
All looks good to me!

@dvir001
Copy link
Contributor

dvir001 commented Oct 18, 2024

image

Air canister sucks

@dvir001 dvir001 self-requested a review October 18, 2024 12:29
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 18, 2024
@dvir001 dvir001 changed the title Update NSF Interceptor Interceptor (Shuttle Update) Oct 18, 2024
@dvir001 dvir001 changed the title Interceptor (Shuttle Update) Interceptor (Update Shuttle) Oct 18, 2024
@dvir001 dvir001 merged commit f0739a9 into new-frontiers-14:master Oct 18, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants