Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big bug fixing part 1 #2161

Merged
merged 74 commits into from
Oct 13, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Oct 6, 2024

Trying to fix some issues.

🆑

  • tweak: The price of the Bocadillo is increased to $23500.
  • tweak: The amount of cloth required to craft altars has been increased to 3.

@github-actions github-actions bot added the No C# label Oct 6, 2024
@dvir001 dvir001 requested a review from whatston3 October 6, 2024 20:27
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Oct 6, 2024
@github-actions github-actions bot added C# and removed No C# labels Oct 6, 2024
@github-actions github-actions bot added the YML label Oct 6, 2024
@github-actions github-actions bot added Map-Shuttle Map - Shuttle and removed YML labels Oct 6, 2024
@github-actions github-actions bot added the Map-Outpost Map - Outpost label Oct 6, 2024
@github-actions github-actions bot added the Map-Dungeon Map - Dungeon label Oct 12, 2024
@github-actions github-actions bot added the Map-Admin Map - For admin use label Oct 12, 2024
@dvir001 dvir001 changed the title Workflow Edits Big bug fixing part 1 Oct 13, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Oct 13, 2024

@whatston3 Ok so the integration tests workflow is set to off again and I will restore them back on in another PR,
We should have this merged before to clear issues so we can just continue working on this without having tests fails on open PR's.

@dvir001 dvir001 mentioned this pull request Oct 13, 2024
2 tasks
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted a lot of changes, bugfixes here (Delta deep fryer, fixes to triggered debug assertions) are useful. Gallery looks nice, that's a whole lot of crayons, but seems fine.

Restored the Rosebuds, the golden rose, and restored the GPS to the tables they were in. Consolidated BaseWallmount and BaseStructureWallmount, works well under test.

Changed maps seem to load fine. Approving this.

@whatston3 whatston3 merged commit 6d4a4d9 into new-frontiers-14:master Oct 13, 2024
16 checks passed
FrontierATC added a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-Admin Map - For admin use Map-Dungeon Map - Dungeon Map-Shuttle Map - Shuttle S: Needs Review This PR is awaiting reviews Sprites YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants