-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprints #2114
Blueprints #2114
Conversation
RSI Diff Bot; head commit 2d6c058 merging into 56b290b Resources/Textures/_NF/Objects/Specific/Research/rped.rsi
Resources/Textures/_NF/Objects/Storage/Cases/documentcaseshort.rsi
Resources/Textures/_NF/Objects/Tools/blueprints.rsi
Resources/Textures/_NF/Structures/Machines/blueprint_printer.rsi
|
I think this feature could be really useful, will give it a look. I might look into getting something that can pull in researched recipes, so anything that's researchable can be printed off without needing to define extra entities, but man this was really fast. |
Man, halfway through this PR I wished I wasn't C#-illiterate to make it happen. |
Gonna add some blueprints that can't be copied/faxed as exped loot and then I'm done with this. |
I think that all blueprints should be destroyed on faxing (so a copy does nothing, and a "send" destroys the original). If you don't have this, the value of selling a blueprint is questionable. I'll get this working in short order, and I can add it to this if you'd like, or give you the diff. |
Sounds good to me. Just add to this PR then. For now I just removed "faxable" component from exped loot blueprint parent. |
A'ight, it is done. |
I think the next step is to make the blueprints costs small number of sci points to print (Can be in later PR) |
Also please don't kill me but keep the NF in entity names as suffix, not prefix. |
I've done it this way, because I believe sooner or later upstream will add a bunch of blueprints and we'll have some issues with IDs because of that. |
I doubt that selling blueprints to players will ever become meta |
Ugh, wait. Wdym? Suffix goes to the end of the ID, prefix goes to the beginning of the ID, is it not? NF is a suffix there. |
*prefix my bad I been slowly fixing it all to be NFEntity and not EntityNF |
Ugh, sure. 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSI validator passes on whatston3#4, no changes to sprites in the meantime, should be good. Happy with the state of this.
Ideally, I think blueprints should be restricted in terms of what machines accept them (i.e. no salvage blueprints in medical techfabs), but otherwise this seems fine.
I'd like a second pair of eyes on this, but it seems good to me. Destruction on fax send/copy seems useful for sensitive docs, might be have for other things.
Nicely done, good feature.
What if we removed the BlueprintReceiver from the autolathe and tinkered with the techfabs that would accept each blueprint type? |
Here's a set of changes that should enable it.
Here's a trivial video of the system in use, showing a science-labelled blueprint failing to insert in a med/ammofab, then a blueprint being inserted into each successfully. 2024-09-30.12-50-47.mp4 |
I'm ugh still not sold on the idea of limiting which techfab/lathe can take which blueprints, I think it mostly detracts from QoL side of things: the way I think this feature going to work is that majority of players will get 1-2 blueprints with something small that needs to be produced in fairly large numbers (like T3 parts, power cells or something like that), but if they need another lathe only to use that 1-2 blueprints then.. Why even bother at this point? Worse yet, if you need 2 blueprints only to find out that you need 2 more lathes for them to work. |
Not that lathes are hard to acquire, but the proposed feature feels like unnecessary complication to me. I might be wrong though. |
Erhard are you saying that if I put the blueprint into a service techfab that fabricator should be able to thereafter make whatever the blueprint was for? That a service fabricator could, with the proper blueprint, make recipes that otherwise would be unlocked for the exosuit fabricator? |
The counterpoint to this is that, if we were able to get a bunch of blueprints, and for pretty much anything, if you can insert them into anything, the separation between techfabs becomes moot. Not insisting on this, but I do think that some separation might be useful. Regardless, I've touched up a few of the sprites, the in-hand blueprints looked a bit odd to me having only one shade in the text and the coloured background. Thoughts? |
Perhaps then you could also add a universal techfab that accepts all blueprints (arriving back at the autolathe point, but gating it behind other research) |
I don't think that it is a bad thing, because at this point player spent a bit of effort into making his favorite techfab into ultimate fabricator unit that is horrendously annoying to use due to how long the list of craftable items has become. I don't think that this is going to be a common occurrence though. A thought (that I'm not going to act upon right now in this PR): maybe limit blueprints shenanigans to autolathe then, just like it was in the base game? Will make the machine relevant again.
Looks way better than original ones, good stuff. |
Yes. At least now. |
I think the idea for a master control lathe is a good one. Having some kind of large multiblock lathe that can accept all materials and build all things is probably a good idea for someone who wants to make a manufacturing hub. But downstream of that I do not think that it connects that lathes that are specialized for a task, such as an exosuit fabricator, are equipped to produce ammunition. Unless the thinking here is that every lathe is exactly the same with a different candy shell. As it stands aren't there complications in that not all lathes will accept all materials? |
imo if a lathe can make something as complicated as articulated borg's appendages or MMI, then it can produce something as dumb as ammo (provided it has instructions - a blueprint - and materials). miracles of far-future fdm printing or whatever. the fact that you can put a blueprint into a lathe doesn't mean that you will. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
About the PR
Upstream introduced new feature - blueprints. This PR slightly expands upon it by adding more blueprints that could be printed by scientists and sold to players.
Why / Balance
Hopefully this will give a small boost to interaction between science players and the rest of the server.
How to test
Media
Requirements
Breaking changes
Changelog
🆑 erhardsteinhauer