Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Empress tiny fans with directional fans. #2104

Merged
merged 6 commits into from
Oct 12, 2024

Conversation

dustylens
Copy link
Contributor

About the PR

The wealth of tiny fans on the Empress have been swapped out.
Everything else seemed to be within code. NFSD stuff is weird.

Why / Balance

Compliance.

How to test

Check the doors. Even that sneaky one in the freezer.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Update Empress tiny fans with directional fans.

@VividPups
Copy link
Contributor

In reference to the bug report https://discord.com/channels/1123826877245694004/1290643394758049935 Could the medical door also be fix to be the same as the WASP

@dustylens
Copy link
Contributor Author

That door is common access. Outside of the specific color is there a reason why it wouldn't be a similar security level door to the NFSD common access airlocks elsewhere in the ship?

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, YAML's simple, rotated the freezer fan to be pointing towards the inside of the freezer.

Approving and merging.

@whatston3 whatston3 merged commit 4a6c0b2 into new-frontiers-14:master Oct 12, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants