Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Anchor tiny fans with directional fans. #2087

Conversation

dustylens
Copy link
Contributor

About the PR

Tiny fans out directional fans in.
Tiny fans out directional fans in.

Why / Balance

Frontier hazing ritual.

How to test

Check dem doors.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Replaces Anchor tiny fans with directional fans.

arimah
arimah previously requested changes Sep 27, 2024
Copy link
Contributor

@arimah arimah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tiniest of fans has been forgotten, neglected, rejected, left to spin all alone:

image

@arimah
Copy link
Contributor

arimah commented Sep 27, 2024

After having a good long look at the Dart-X, I've discovered numerous other issues with the ship. It will be making a separate PR to retire it pending a rework.

@arimah arimah closed this Sep 27, 2024
@arimah
Copy link
Contributor

arimah commented Sep 27, 2024

Iiiii closed the WRONG DANG PR. I'm so sorry.

@arimah arimah reopened this Sep 27, 2024
@dustylens
Copy link
Contributor Author

dustylens commented Sep 27, 2024

Dang.

Shoulda scanned the yml again.

I'll update it right now, unless it seems a bit wonky of a position to rate a directional fan.

Edit: Eh updated

ss+(2024-09-27+at+03 47 43)

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Oct 11, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directional fans seem fine, all 8 accounted for on the docks.

I've restored the shield sign by the mercenary locker (picture attached at the bottom of the post - improvements on sprites more than welcome). I've also added a ~30% margin to the price to put it in line with other expedition ships

As with the Sprinter, I'm going to give this one a few days for additional review, but it seems fine to my eyes.

image

@whatston3 whatston3 dismissed arimah’s stale review October 11, 2024 22:25

Tiny fan was removed, the replacement directional fan seems acceptable, changes have been made.

@ErhardSteinhauer ErhardSteinhauer merged commit 8742f31 into new-frontiers-14:master Oct 13, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants