Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Server Configuration (Port From Einstein-Engines) #2077

Conversation

VMSolidus
Copy link
Contributor

About the PR

Ported from Simple-Station/Einstein-Engines#901

Jetpacks can now be configured via CCVar in a server's TOML file to allow for certain behaviors that people have repeatedly asked for, and were denied by Wizden on the basis that, "Wizden doesn't want this on their servers". Well the request has reached my lap, and my response to this is, "I have the power to give that choice directly to individual servers."

Here you go. Enjoy.
This PR makes it so that jetpacks can be set in Server Configuration to

  • Be usable in ANY condition, even on grids with gravity
  • Be usable in zero gravity, even on grids
  • Or set the 2 new CVars to false, and it'll just work like it did before.

Why / Balance

By extremely popular request.

How to test

Put on a jetpack. Go to some random debris in space. Zoom over the debris with a jetpack since it has no gravity generator.

Media

None needed

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog

🆑

  • add: Jetpacks now work in zero gravity.
  • add: New CCVar "jetpack.enable_anywhere" allows server hosts to optionally make it so that jetpacks can be used anywhere, even in gravity and on grids.
  • add: New CCVar "jetpack.enable_in_no_gravity" allows server hosts to optionally disable jetpacks being usable in zero gravity.

Jetpacks can now be configured via CCVar in a server's TOML file to
allow for certain behaviors that people have repeatedly asked for, and
were denied by Wizden on the basis that, "Wizden doesn't want this on
their servers". Well the request has reached my lap, and my response to
this is, "I have the power to give that choice directly to individual
servers."

Here you go. Enjoy.
This PR makes it so that jetpacks can be set in Server Configuration to
- Be usable in ANY condition, even on grids with gravity
- Be usable in zero gravity, even on grids
- Or set the 2 new CVars to false, and it'll just work like it did
before.

:cl:
- add: Jetpacks now work in zero gravity.
- add: New CCVar "jetpack.enable_anywhere" allows server hosts to
optionally make it so that jetpacks can be used anywhere, even in
gravity and on grids.
- add: New CCVar "jetpack.enable_in_no_gravity" allows server hosts to
optionally disable jetpacks being usable in zero gravity.
@github-actions github-actions bot added the C# label Sep 25, 2024
@VMSolidus VMSolidus changed the title Jetpack Server Configuration (#901) Jetpack Server Configuration (Port From Einstein-Engines) Sep 25, 2024
@whatston3
Copy link
Contributor

whatston3 commented Sep 26, 2024

I've got a set of suggestions up on whatston3:frontier-station-14:Port-Jetpack-Server-Configuration-suggestions, I'd be curious of your thoughts.

  • I think the comp.Enabled in your CanEnableOnGrid check is flipped, and should be !comp.Enabled.
  • This suggestion separates EE CVars into a namespaced folder. I'm not sure how you work with EE code on Delta (if I have something mixed up here, my apologies), but this seems better than using the base CCVars to me.
  • I've added a few checks on whether the jetpack's user is parented to anything - we shouldn't be able to enable the jetpack when in a duffelbag or on a vehicle, and should disable them when reparenting regardless of which of the CVARs are enabled.

This seems like a fun feature, and while it might trivialize salvage a bit, I think the fun of goofing around on jetpacks seems well worth it. Thank you for the port.

@dvir001
Copy link
Contributor

dvir001 commented Sep 26, 2024

I've got a set of suggestions up on whatston3:frontier-station-14:Port-Jetpack-Server-Configuration-suggestions, I'd be curious of your thoughts.

  • I think the comp.Enabled in your CanEnableOnGrid check is flipped, and should be !comp.Enabled.
  • This suggestion separates EE CVars into a namespaced folder. I'm not sure how you work with EE code on Delta (if I have something mixed up here, my apologies), but this seems better than using the base CCVars to me.
  • I've added a few checks on whether the jetpack's user is parented to anything - we shouldn't be able to enable the jetpack when in a duffelbag or on a vehicle, and should disable them when reparenting regardless of which of the CVARs are enabled.

This seems like a fun feature, and while it might trivialize salvage a bit, I think the fun of goofing around on jetpacks seems well worth it. Thank you for the port.

EE CCVars.cs need to go into EE CCVars.cs like the NF one 👍

@Cheackraze Cheackraze merged commit 63dc398 into new-frontiers-14:master Oct 3, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants