fix: update internal certificate documents #141
Conversation
There was a problem hiding this comment.
Thank you for updating! I left some suggestions on adjusting the note phrasing to use active voice and to use the "important" admonition instead of "note" as I think it conveys the severity better. Also I left some overall suggestions, and one question but should the note also be included in the version 5.3 page (versioned_docs/version-5.3/02.deploying/01.production/04.internal/04.internal.md)?
Please let me know if there are any questions, thanks again!
versioned_docs/version-5.4/02.deploying/01.production/04.internal/04.internal.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-5.4/02.deploying/01.production/04.internal/04.internal.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-5.4/02.deploying/01.production/04.internal/04.internal.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-5.4/02.deploying/01.production/04.internal/04.internal.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-5.4/02.deploying/01.production/04.internal/04.internal.md
Outdated
Show resolved
Hide resolved
Yes we should...thanks for catching that! |
Co-authored-by: Sunil Singh <[email protected]>
holyspectral
force-pushed
the
update-internal-certificates-5-4
branch
from
58088cb to
1d845b6
Compare
|
@sunilarjun I've merged your suggestion into the branch with one question. Feel free to let me know if you have any questions. Thanks! |
|
@sunilarjun I've updated the PR. Please let me know if any change is still required. |
|
@williamshen9999 please also take a look at the doc and let me know if you have any feedback. |
Sure, I'm checking it now. |
|
it looks good to me. thanks. |
Update internal certificate related document.
Note: This should only be merged after 5.4.2 is released.