Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 12.rancher_sso_rbac.md #140

Merged
merged 20 commits into from
Jan 2, 2025
Merged

Conversation

brunoebernardi
Copy link
Contributor

Hi Nuno. I'm creating this documentation based on the NVSHAS-9463 case and some experiences I've had with customers in some support cases. I thought it would be interesting to include all these topics and use cases in the documentation, but please feel free to modify it if necessary. Thanks!

Hi Nuno. I'm creating this documentation based on the NVSHAS-9463 case and some experiences I've had with customers in some support cases. I thought it would be interesting to include all these topics and use cases in the documentation, but please feel free to modify it if necessary. Thanks!
@sunilarjun sunilarjun self-requested a review December 16, 2024 18:21
Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this page addition! I left some review comments on adjusting some phrasing/grammar and also could you please add this page to the versioned_docs v5.4 similar section (versioned_docs/version-5.4/08.integration)? Please let me know if you have any questions or if you need any help with versioning I can assist, thank you!

docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
docs/08.integration/12.rancher_sso_rbac.md Outdated Show resolved Hide resolved
@brunoebernardi
Copy link
Contributor Author

Hi @sunilarjun, Thank you for reviewing the PR and including suggestions. I've made the suggested adjustments, and I would appreciate it if you could review and check for approval when possible.

Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the feedback! Content is approved and merging in.

@sunilarjun sunilarjun merged commit 1a916f2 into neuvector:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants