Code Cleanup #28
Open
Code Cleanup #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 14, 2025 17:41
…ion types; it will now process all available types when this occurs.
…io.test.docx") and be placed in directories that do not initially exist at runtime, through the power of PathLib!
…for the NeuroPoly wiki) is now placed in the same place as everything else.
…ueries doesn't exist; it will now just notify the user with a warning instead + fix for user requesting 0 publication types
…ollution in preparation for future refactoring
…now you can mix both files and raw identifiers if you want! This is part of an overall CLI refactor, to preparation for automated testing.
…CV's contents to another.
…appropriate pre-run validations)
…tions can be called *without* needing a shell to call them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly to resolve a number of potential issues and code quality concerns in the current state of the repository. In particular, this PR aims to fix the following (among other minor fixes):
ospackage, which can be unsafe (or, at least, less safe thanpathlibfor what its being used for)Once this pass is completed, the next step will be implementing automated testing to help ensure that further refactors/tests don't break existing functionality (which I am currently testing manually). Cheers!