Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI option for registering section-segment mapping info #27

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

WeinaJi
Copy link
Contributor

@WeinaJi WeinaJi commented Mar 6, 2024

No description provided.

@WeinaJi WeinaJi changed the title add CLI option for registering report mapping add CLI option for registering section-segment mapping into Mar 11, 2024
@WeinaJi WeinaJi changed the title add CLI option for registering section-segment mapping into add CLI option for registering section-segment mapping info Mar 11, 2024
@WeinaJi WeinaJi marked this pull request as ready for review March 11, 2024 08:23
@WeinaJi WeinaJi requested review from pramodk and jorblancoa March 11, 2024 08:24
commonutils.py Outdated Show resolved Hide resolved
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

there are some BBP specific conventions / details like "Mosaic" target etc but I feel it's similar to coreneuron reporting extensions. So LGTM.

@pramodk pramodk merged commit d40caf6 into master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants