Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTList and add signals #3291

Merged
merged 14 commits into from
Dec 15, 2024
Merged

Remove HTList and add signals #3291

merged 14 commits into from
Dec 15, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 13, 2024

No description provided.

@azure-pipelines Azure Pipelines
Copy link

✔️ 38eeb36 -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (bf6a457) to head (b2a14e9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrncvode/netcvode.cpp 96.42% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3291   +/-   ##
=======================================
  Coverage   67.06%   67.07%           
=======================================
  Files         572      571    -1     
  Lines      111115   111055   -60     
=======================================
- Hits        74520    74486   -34     
+ Misses      36595    36569   -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino changed the title HTList funerals Remove HTList and add signals Dec 14, 2024
@azure-pipelines Azure Pipelines
Copy link

✔️ ca1a779 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
JCGoran
JCGoran approved these changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, the code looks much more readable! Only need minor clarifications about the implementation.

src/utils/signal.hpp Outdated Show resolved Hide resolved
src/utils/signal.hpp Outdated Show resolved Hide resolved
Nicolas Cornu added 2 commits December 15, 2024 20:30
@alkino alkino enabled auto-merge (squash) December 15, 2024 19:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines Azure Pipelines
Copy link

✔️ b2a14e9 -> Azure artifacts URL

@alkino alkino merged commit 6ab042f into master Dec 15, 2024
36 checks passed
@alkino alkino deleted the cornu/burp branch December 15, 2024 20:19
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #240347 (:no_entry:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCGoran JCGoran JCGoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @JCGoran