-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge CMakeLists.txt #3272
Draft
1uc
wants to merge
876
commits into
master
Choose a base branch
from
1uc/nmodl-merge-cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Merge CMakeLists.txt #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NRN we depend on the target `nmodl` to ensure that when we run `nrnivmodl -coreneuron` the binary `nmodl` exists. We need to also ensure that everything `nmodl` needs to works is present. This fixes a dependency bug on certain copied files by making the target for copying the files a dependency of `nmodl`. NMODL Repo SHA: BlueBrain/nmodl@b78c3f3
* Fix array variables. These are the code generation changes required for: #2779 The solution is to fill `nrn_prop_param_size` with the number of doubles, not number of variables. NMODL Repo SHA: BlueBrain/nmodl@f6821ce
…dl#1244) - If `-DNMODL_ENABLE_PYTHON_BINDINGS=OFF` then there is no need to generate AST and other wrapper classes for Pybind11. - Using sympy-based solvers does not require Python bindings to be enabled. Avoid confusing warning when using nmodl binary. - When someone tries to use the nmodl module via Python, the warning is still preserved. ```console $ nmodl mod_examples/sparse.mod [NMODL] [warning] :: Python bindings are not available with this installation .. $ nmodl mod_examples/sparse.mod $ python3.11 -c "import nmodl" [NMODL] [warning] :: Python bindings are not available with this installation ``` NMODL Repo SHA: BlueBrain/nmodl@8eb88e4
- when neuron is built with nmodl then nmodl related files should be installed in <prefix>/ and not in <prefix>/nmodl/.data - <prefix>/nmodl/.data is used when we build standalone wheels - add one mod file using sparse solver - nmodl will automatically use sympy solver NMODL Repo SHA: BlueBrain/nmodl@2fb037e
It was dead code NMODL Repo SHA: BlueBrain/nmodl@8285f26
Instead of setting the conductance as: g = g + g0 * exp(-(t - t0)/tau) we set it to g += g0 where `g0` is the argument passed to NET_RECEIVE, i.e. the weight. This allows for an analytic solution, that can be tested. NMODL Repo SHA: BlueBrain/nmodl@ada65df
Random collection of fixups to make hh.mod work. --------- Co-authored-by: Luc Grosheintz <[email protected]> NMODL Repo SHA: BlueBrain/nmodl@b451d39
NMODL Repo SHA: BlueBrain/nmodl@299c249
The idea is to generate the references, but not check that there are no differences. Doing so allows us to push the changes automatically to `nmodl-references`. NMODL Repo SHA: BlueBrain/nmodl@0e69948
This adds a test that consists of the following: 1. Two sections. 2. One current clamp at he beginning of the first section. 3. A synapse connecting the ends of the sections. We record the voltage at a few locations along the two sections and assert (and optionally plot) that the values haven't changed a lot. NMODL Repo SHA: BlueBrain/nmodl@8126294
Adds tests the demonstrates how the voltage `v` behaves when passed to functions or procedures. NMODL Repo SHA: BlueBrain/nmodl@49da686
…INT block (BlueBrain/nmodl#1260) NMODL Repo SHA: BlueBrain/nmodl@a8f1829
Co-authored-by: Nicolas Cornu <[email protected]> NMODL Repo SHA: BlueBrain/nmodl@8ff93be
* Assign default value in PARAMETER block. A parameter can be assigned a value inside the PARAMETER block. If no value is assigned the default is `0.0`. This commit fixes a bug when no value was specified. * Improve test for PARAMETER. NMODL Repo SHA: BlueBrain/nmodl@322bbf0
--------- Co-authored-by: Nicolas Cornu <[email protected]> NMODL Repo SHA: BlueBrain/nmodl@f828be9
Rename a small number of Python keywords appearing in generated strings we forward to sympy. * Don't use 'pi'. NMODL Repo SHA: BlueBrain/nmodl@f28a335
The revised format only prints the first trace, before entering the `CodePrinter`. It also refactors the code to prepare for injecting a detailed blame printer, when needed. NMODL Repo SHA: BlueBrain/nmodl@24706b5
This code is shared between NEURON and CoreNEURON. Therefore, it's moved the common base class. NMODL Repo SHA: BlueBrain/nmodl@c0994d7
NMODL Repo SHA: BlueBrain/nmodl@55131b5
Add the code for printing `net_move` for NEURON+nmodl. Also adds a usecase demonstrating the behaviour of `net_move`. NMODL Repo SHA: BlueBrain/nmodl@c96434a
This comment has been minimized.
This comment has been minimized.
✔️ f77dec4 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✔️ 981cefe -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 97b3fa4 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ e3c2012 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
✔️ 3cab2ee -> Azure artifacts URL |
CI doesn't run if it's not against the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.