-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark RXD test as skip on Ubuntu 22+ #3080
Conversation
✔️ 703ff24 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3080 +/- ##
==========================================
+ Coverage 67.27% 67.39% +0.11%
==========================================
Files 571 573 +2
Lines 104870 104927 +57
==========================================
+ Hits 70556 70720 +164
+ Misses 34314 34207 -107 ☔ View full report in Codecov by Sentry. |
✔️ 46c4408 -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Remember to add an Issue to investigate further.
Which versions exactly are faulty? In particular is either Ubuntu 22.04 or 22.09 affect? |
At least 22.04 and 24.04 are affected, but not 20.04. I can't say anything about 22.09 since I don't have a Docker image of that one. |
Quality Gate passedIssues Measures |
✔️ b8081dd -> Azure artifacts URL |
Along with neuronsimulator/nrn-build-ci#73 we can finally make the build CI green again: https://github.com/neuronsimulator/nrn-build-ci/actions/runs/10995314679 |
This is a workaround, not a fix, for neuronsimulator/nrn-build-ci#66.
To minimize headaches, it shouldn't have any impact on anything other than that one test being marked as
skip
on Ubuntu 22 and newer.See for instance https://github.com/neuronsimulator/nrn-build-ci/actions/runs/10955119487/job/30418368871