Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark RXD test as skip on Ubuntu 22+ #3080

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Mark RXD test as skip on Ubuntu 22+ #3080

merged 9 commits into from
Sep 25, 2024

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Sep 19, 2024

This is a workaround, not a fix, for neuronsimulator/nrn-build-ci#66.
To minimize headaches, it shouldn't have any impact on anything other than that one test being marked as skip on Ubuntu 22 and newer.
See for instance https://github.com/neuronsimulator/nrn-build-ci/actions/runs/10955119487/job/30418368871

Copy link

✔️ 703ff24 -> Azure artifacts URL

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (1d812c8) to head (b8081dd).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   67.27%   67.39%   +0.11%     
==========================================
  Files         571      573       +2     
  Lines      104870   104927      +57     
==========================================
+ Hits        70556    70720     +164     
+ Misses      34314    34207     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ 46c4408 -> Azure artifacts URL

@JCGoran JCGoran changed the title Mark RXD test as xfail on Ubuntu 22+ Mark RXD test as skip on Ubuntu 22+ Sep 19, 2024
@JCGoran JCGoran marked this pull request as ready for review September 19, 2024 16:50
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Remember to add an Issue to investigate further.

test/rxd/testutils.py Outdated Show resolved Hide resolved
test/rxd/testutils.py Outdated Show resolved Hide resolved
@1uc
Copy link
Collaborator

1uc commented Sep 20, 2024

Which versions exactly are faulty? In particular is either Ubuntu 22.04 or 22.09 affect?

@JCGoran
Copy link
Collaborator Author

JCGoran commented Sep 20, 2024

Which versions exactly are faulty? In particular is either Ubuntu 22.04 or 22.09 affect?

At least 22.04 and 24.04 are affected, but not 20.04. I can't say anything about 22.09 since I don't have a Docker image of that one.

Copy link

Copy link

✔️ b8081dd -> Azure artifacts URL

@JCGoran
Copy link
Collaborator Author

JCGoran commented Sep 25, 2024

Along with neuronsimulator/nrn-build-ci#73 we can finally make the build CI green again: https://github.com/neuronsimulator/nrn-build-ci/actions/runs/10995314679

@pramodk pramodk merged commit 3e45370 into master Sep 25, 2024
38 checks passed
@pramodk pramodk deleted the jelic/skip_rxd_test branch September 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants