Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iv update. Allows build types Fast and FastDebug. #2747

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

nrnhines
Copy link
Member

Uses latest iv master which incorporates neuronsimulator/iv#50

@nrnhines nrnhines requested review from pramodk and 1uc February 19, 2024 12:43
@pramodk pramodk enabled auto-merge (squash) February 19, 2024 12:49
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nrnhines
Copy link
Member Author

nrnhines commented Feb 19, 2024

Not preventing merge of this PR, but I notice on my new machine Intel® Xeon(R) w3-2435 × 16 that -DCMAKE_BUILD_TYPE=Fast, which uses

cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=install -DPYTHON_EXECUTABLE=`which python` -DCMAKE_BUILD_TYPE=Fast -DNRN_ENABLE_TESTS=ON
-- COMPILE FLAGS | -O3 -flto -march=native   -fopenmp-simd

generates very many warnings and

$ ninja test
...
97% tests passed, 6 tests failed out of 199

Total Test time (real) = 163.73 sec

The following tests FAILED:
	  1 - unit_tests::testneuron (Failed)
	  3 - unit_tests::benchmarks (Failed)
	 16 - pytest_coreneuron::basic_tests_py3.12 (Failed)
	 72 - hoctests::test_neurondemo_py (Failed)
	 81 - rxdmod_tests::rxd_tests (Failed)
	185 - external_nrntest (Failed)

@nrnhines
Copy link
Member Author

For another data point on an Apple M1 (Ventura 13.6, clang 15.0.0)

hines@Michaels-MacBook-Pro-2 build % cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=install -DPYTHON_EXECUTABLE=`which python3` -DCMAKE_BUILD_TYPE=Fast -DNRN_ENABLE_TESTS=ON
-- COMPILE FLAGS | -O3     -openmp-simd

many fewer warnings

99% tests passed, 2 tests failed out of 199

Total Test time (real) =  74.12 sec

The following tests FAILED:
	 16 - pytest_coreneuron::basic_tests_py3.12 (Failed)
	 81 - rxdmod_tests::rxd_tests (Failed)

Copy link

✔️ 81ee95e -> Azure artifacts URL

@1uc
Copy link
Collaborator

1uc commented Feb 19, 2024

It was my understanding that the test failure when using Fast is why Olli introduced FastDebug. It's a compromise forcing the compiler to generate really bad code, e.g. because it's not allowed to inline with Debug (cost: 10x), and allowing it to generate code that slightly changes the results, e.g. due to FMA or SIMD.

@pramodk pramodk merged commit ee736d4 into master Feb 19, 2024
34 of 35 checks passed
@pramodk pramodk deleted the hines/nrn-update-iv branch February 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants