Fixes for RNG, part 1 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrnhines
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
I approve this but am curious about the way we identify model variants by the pull request number. Is that stable when the pull request is merged to the master and the pr or branch is removed? I suppose we will become aware when the the ci fails. At least on github, the old pr numbers are not reused for future pull requests.
|
I think we should be fine, we are querying URLs of the form: and this seems to return the right zip file regardless if the PR is merged or the branch deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for models that need trivial(ish) fixes.
MODELS_TO_RUN=32992 180373 151731 147757 155602 189347 112685 139150 232097 168314 257027 157157 2015410 106551 128559 105507 127021 183300 51781 149739 137259 185513 119283 126640
Related NEURON PRs that required this change:
Models fixed: