Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws key #278

Merged
merged 41 commits into from
May 6, 2021
Merged

aws key #278

merged 41 commits into from
May 6, 2021

Conversation

alishakodibagkar
Copy link
Contributor

@alishakodibagkar alishakodibagkar commented May 5, 2021

Addresses Issue #261 and Issue #250

  • adding .aws.sh with aws keys
  • updating config.yml to run .aws.sh
  • deleting .travis.yml
  • updating Neuron_trace.py and session.py to properly assign use_https = False
  • updating test_Neuron_trace: changing url_seg to 's3://open-neurodata/brainlit/brain1_segments', setting use_https = False for test_swc and test_s3
  • updating notebooks seg_pipeline_demo.ipynb and vizualization.ipynb to remove swc.py (from Issue Brainlit Documentation Fixes #250)
  • commenting out portions of: seg_pipeline_demo.ipynb, vizualization.ipynb, adaptive_thresh_tutorial.ipynb, downloading_brains.ipynb, loading.ipynb, neighborhood_vizualization.ipynb due to "kernel died" error

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #278 (8e76529) into develop (7794dad) will increase coverage by 5.53%.
The diff coverage is 96.03%.

@@             Coverage Diff             @@
##           develop     #278      +/-   ##
===========================================
+ Coverage    47.36%   52.89%   +5.53%     
===========================================
  Files           45       47       +2     
  Lines         3752     4231     +479     
===========================================
+ Hits          1777     2238     +461     
- Misses        1975     1993      +18     
Impacted Files Coverage Δ
brainlit/utils/Neuron_trace.py 91.29% <ø> (ø)
brainlit/utils/session.py 97.20% <ø> (ø)
...gorithms/connect_fragments/tests/grid_generator.py 94.75% <94.75%> (ø)
...s/connect_fragments/dynamic_programming_viterbi.py 97.91% <97.91%> (ø)
brainlit/algorithms/connect_fragments/__init__.py 100.00% <100.00%> (ø)
brainlit/viz/swc2voxel.py 64.56% <0.00%> (+0.78%) ⬆️

Copy link
Member

@tathey1 tathey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@tathey1 tathey1 merged commit 7d8ae6f into develop May 6, 2021
@tathey1 tathey1 deleted the issue_261 branch January 14, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants