[REF] Remove container-internal ports and unneeded graph config vars #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
NB_GRAPH_ADDRESS
NB_GRAPH_PORT
*NB_GRAPH_IMG
NB_NAPI_PORT
*NB_FAPI_PORT
*(*) Note that the container
environment
variables corresponding to these options still exist and are still expected/used by scripts within the Compose stack, their port values are just now hardcoded in the container environmentNB_GRAPH_PORT
env var; the n-API will useNB_API_PORT
from the container environment to determine what port to launch uvicorn onChecklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: