-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add singularity command switcher #442
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to switch between Docker and Singularity execution environments when retrieving data. The change involves adding a toggle button group to the GetDataDialog component, which allows users to select their preferred command, and updating the copy command functionality to use the selected command. Sequence diagram for command copy interactionsequenceDiagram
actor User
participant UI as GetDataDialog
participant System as System Clipboard
User->>UI: Clicks command type toggle
UI->>UI: Updates command display
User->>UI: Clicks copy button
UI->>System: Copies selected command
UI->>UI: Shows copy confirmation
Class diagram for GetDataDialog componentclassDiagram
class GetDataDialog {
+boolean open
+function onClose()
-string DOCKER_RUN_COMMAND
-string SINGULARITY_RUN_COMMAND
-string commandType
-boolean showPopover
-HTMLButtonElement anchorEl
+handleCopyClick(event)
+handlePopoverClose()
+handleChange(event, newCommand)
+render()
}
note for GetDataDialog "New commandType state and
Singularity command added"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To make tests run locally with the custom theme Not entirely sure still why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @surchs!
Left a couple of comments, please take a look. Other than those 🧑🍳
P.S. don't forget to add a PR label
Co-authored-by: Arman Jahanpour <[email protected]>
Should we release off of this PR as well? Thoughts @neurobagel/dev ? |
After discussing this at standup today, we decided to first figure out why component tests are passing locally for @rmanaem without the |
@surchs Did u figure out why the component test suit was failing on your machine? |
Changes proposed in this pull request:
NOTE: If this pull request is to be released, the release label must be applied once the review process is done to avoid the local and remote from going out of sync as a consequence of the
bump version
workflow runChecklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
query-tool-results
files in the neurobagel_examples repo have been regeneratedFor new features:
For bug fixes:
Summary by Sourcery
Add a command switcher to allow users to choose between Docker and Singularity when running data retrieval commands.
New Features:
Tests: