Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use logging and let the user reduce the verbosity #162

Open
1 task done
surchs opened this issue Jun 15, 2023 · 3 comments
Open
1 task done

[ENH] Use logging and let the user reduce the verbosity #162

surchs opened this issue Jun 15, 2023 · 3 comments

Comments

@surchs
Copy link
Contributor

surchs commented Jun 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

New feature

Right now we tell the user good news with a print statement, e.g:

bagel-cli/bagel/cli.py

Lines 70 to 74 in 0ed0e4d

print(
"Processing phenotypic annotations:\n"
f" {'Tabular file (.tsv):' : <{space}} {pheno}\n"
f" {'Data dictionary (.json):' : <{space}} {dictionary}\n"
)

which means they can't turn that off if they'd prefer (e.g. when they run this thing a couple hundred times in a row).
We should instead use a logger (https://docs.python.org/3/library/logging.html).
This has other nice benefits such as:

  • I can choose what level of "news" I'd like to see
  • I can have it log to a file
  • and probably others I forget

In short: let's do this.

Unclear documentation

No response

@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jul 16, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@alyssadai alyssadai added flag:schedule Flag issue that should go on the roadmap or backlog. and removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again labels Oct 21, 2023
@surchs surchs removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Oct 23, 2023
Copy link

github-actions bot commented Jan 7, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jan 7, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants