Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TST] Remove unneeded env file mount from test docker-compose.yml #366

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[TST] Remove unneeded env file mount from test docker-compose.yml #366

merged 3 commits into from
Oct 25, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 24, 2024 •
edited by rmanaem
Loading

Changes proposed in this pull request:

  • The entrypoint script used by the graph container no longer expects an actual env file, so this file & its corresponding mount can be removed

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass
  • If the PR changes the SPARQL query template, the default Neurobagel query file has also been regenerated

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-tests Add or improve existing tests label Oct 24, 2024
@alyssadai alyssadai marked this pull request as ready for review October 24, 2024 21:33
@alyssadai alyssadai self-assigned this Oct 25, 2024
@rmanaem rmanaem self-requested a review October 25, 2024 15:39
rmanaem
rmanaem approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion and then 🧑‍🍳

docker-compose.yml Outdated Show resolved Hide resolved
@alyssadai @rmanaem
Fix data directory path
25b9e0a 
Co-authored-by: Arman Jahanpour <[email protected]>
@alyssadai alyssadai merged commit ce22510 into main Oct 25, 2024
7 checks passed
@alyssadai alyssadai deleted the update-compose-config branch October 25, 2024 16:54
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 PR was released in v0.4.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees

@alyssadai alyssadai

Labels
pr-tests Add or improve existing tests released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssadai @rmanaem