-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add endpoint that returns term ID-label mappings for vocab of a given attribute (nb:Assessment
)
#201
Conversation
…oint - crud function processes fetched (temporary) term-label mappings and adds vocab info
Pull Request Test Coverage Report for Build 6565245867
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this impressive PR @alyssadai. This took me a second to work through because it is complex, mostly necessarily, I think. I did leave a couple of comments where I think we can make the code clearer or provide context for the future.
Since this is the cogatlas / assessment tool endpoint, I'd also update the PR title to reflect that.
Take a look, apply what you agree with - everything works so after that: 🧑🍳
nb:Assessment
)
Closes #197
Changes proposed in this pull request:
/attributes
router:/attributes/{data_element_URI}/vocab
{data_element_URI}
validated as enum to flag unrecognized CDEsdata_element_URI=="nb:Assessment"
)Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: