Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch deprecated startup events to lifespan events #152

Open
alyssadai opened this issue Aug 30, 2023 · 6 comments
Open

Switch deprecated startup events to lifespan events #152

alyssadai opened this issue Aug 30, 2023 · 6 comments
Assignees
Labels
PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. refactor Simplifying or restructuring existing code or documentation. someday Not a priority right now, but we want to keep this around to think or discuss more.

Comments

@alyssadai
Copy link
Contributor

The @app.on_event("startup") syntax seems to be deprecated: https://fastapi.tiangolo.com/advanced/events/#alternative-events-deprecated and replaced by https://fastapi.tiangolo.com/advanced/events/#lifespan

We should look into updating the startup checks for defined credentials and allowed origins to follow this new syntax.

Originally posted by @surchs in #151 (comment)

@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Sep 30, 2023
@surchs surchs added type:maintenance refactor Simplifying or restructuring existing code or documentation. labels Oct 24, 2023
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Oct 25, 2023
Copy link

github-actions bot commented Jan 8, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jan 8, 2024
@alyssadai alyssadai added the PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. label Mar 7, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 8, 2024
@samadpls
Copy link
Contributor

Hi @alyssadai, Can i take this issue? 😋

Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label May 27, 2024
@surchs surchs added someday Not a priority right now, but we want to keep this around to think or discuss more. and removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again labels May 27, 2024
@KhushiRajurkar
Copy link

Hello @alyssadai, thank you for your detailed response and guidance!

I’ve reviewed PR #287 and understand that the primary task involves refactoring the lifespan event to align with the latest changes in main.py. I’ve also noted the differences between the implementation in PR #287 and the current version of main.py.

My plan is to:

  1. Update the lifespan function to incorporate all the startup and shutdown logic from the current main.py file.
  2. Ensure compatibility with any new features or changes introduced in the main.py since PR [MNT] Switched to lifespan events #287.
  3. Test the implementation thoroughly to confirm that it works as intended.

I would like to begin working on this and contribute a PR to resolve issue #152. Could you please assign the issue to me?

Thank you!

@alyssadai alyssadai self-assigned this Jan 24, 2025
@alyssadai
Copy link
Contributor Author

Hi @KhushiRajurkar, thanks for your interest in contributing. I've assigned you to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. refactor Simplifying or restructuring existing code or documentation. someday Not a priority right now, but we want to keep this around to think or discuss more.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants