[torch.compile] Dynamic fp8 + rms_norm fusion #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
ProExpertProg
force-pushed
the
luka/rms-norm-fusion-refactor
branch
2 times, most recently
from
81ad334 to
7d1adbf
Compare
ProExpertProg
force-pushed
the
luka/rms-norm-fusion-refactor
branch
from
7d1adbf to
651ebdc
Compare
ProExpertProg
changed the title
csrc/quantization/fused_kernels/fused_layernorm_dynamic_per_token_quant.cu
Outdated
Show resolved
Hide resolved
vllm/_custom_ops.py
Outdated
| @@ -22,6 +22,7 @@ | |||
| supports_moe_ops = False | |||
| with contextlib.suppress(ImportError): | |||
| import vllm._moe_C # noqa: F401 | |||
|
|
|||
There was a problem hiding this comment.
nit: whitespace changes, here and below
|
Reviewed the kernel files and kernel tests. Left some minor comments. LGTM otherwise. |
ProExpertProg
force-pushed
the
luka/rms-norm-fusion-refactor
branch
from
13f84b9 to
194eb6f
Compare
ProExpertProg
requested review from
tlrmchlsmth,
robertgshaw2-neuralmagic,
njhill,
alexm-neuralmagic and
youkaichao
as code owners
ProExpertProg
force-pushed
the
luka/rms-norm-fusion-refactor
branch
from
194eb6f to
7046e4b
Compare
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
…ops to constants Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
- extracted MultiOutputMatch to own file - extracted utils to fx_utils - added named tuples for op keys Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
Signed-off-by: luka <[email protected]>
ProExpertProg
force-pushed
the
luka/rms-norm-fusion-refactor
branch
from
17ff1b9 to
720d537
Compare
Signed-off-by: luka <[email protected]>
ProExpertProg
force-pushed
the
luka/rms-norm-fusion-refactor
branch
from
21abcff to
a70d496
Compare
- add kFp8Type constant for cuda/hip agnostic torch type checking - check contiguous - overflow - reduce number of tests Signed-off-by: luka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the fusion pass to make it easier to add other multi-output patterns. Then it adds dynamic fp8 rmsnorm fusion.