Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cd-1513-ssh-key-endpoint-re-design #243

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Feature/cd-1513-ssh-key-endpoint-re-design #243

wants to merge 3 commits into from

Conversation

thomas-chu123
Copy link
Collaborator

Support the CD-1513 SSH key endpoint re-design task.

  1. Based on the latest dev branch.
  2. Add the new key_type in the exchange key function. Dashboard will be able to add or swap the user/terminal key in in the API function.
  3. Remove the empty SSH key blocking in the endpoint. Please note that the miner will need to be updated since the empty SSH key will need to be taken care of on the miner side to create the ssh-container rather than the ssh-test-container.

The below scenario is verified:

  1. Allocate function with new miner and API code.
  2. Exchange the user or terminal key on the above miner.
  3. Deallocate function with the new miner code.
  4. Allocate function with the miner code on "main" branch and new API code.
  5. Exchange the user key on the above miner.
  6. Deallocate function the miner code on "main" branch and new API code.

@thomas-chu123
feat(support new dual key feature): support key_type in the exchange …
51ff26e 
…key endpoint in the API

modify the container.py to support the dual key (user/terminal)
modify the miner allocate function
modify the register_api.py endpoint for the exchange key docker function
@thomas-chu123
fix(register-api): change the default setting for the exchange key
81f6e6f 
1. change the default key_type to "user" if the frontend didn't specify the type
@thomas-chu123
fix(register_api.py): remove the no ssh key checking
3626cd5 
unblock the input for no ssh key function
@thomas-chu123 thomas-chu123 added the enhancement New feature or request label Jan 14, 2025
@thomas-chu123 thomas-chu123 changed the title Feature/cd 1513 ssh key endpoint re design Feature/cd-1513-ssh-key-endpoint-re-design Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo0haned mo0haned Awaiting requested review from mo0haned

@nauttiilus nauttiilus Awaiting requested review from nauttiilus

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomas-chu123