Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§‘β€πŸ’» show build version #360

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

BuildmodeOne
Copy link
Member

@BuildmodeOne BuildmodeOne commented Nov 4, 2023

image

πŸ€– Generated by Copilot at f12b63d

Summary

πŸš€πŸŽ¨πŸ“

This pull request adds a new feature to the app that allows users to view the version of the app and the result of an API request on a debug page. It also improves the layout and appearance of the debug page by using a spinner, syntax highlighting, and custom CSS classes. It modifies the Dockerfile, package.json, package-lock.json, debug.jsx, personal.jsx, and Debug.module.css files to implement this feature.

Debug page improved
react-syntax-highlighter
Autumn leaves of code

Walkthrough

  • Add syntax highlighting for API result on debug page (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add react-syntax-highlighter library and its dependencies to package.json and package-lock.json files (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Import and use SyntaxHighlighter component from react-syntax-highlighter library in debug.jsx file (link)
  • Define custom CSS classes for styling the code snippet in Debug.module.css file (link)
  • Add loading indicator for API request on debug page (link, link, link, link, link)
    • Import and use Spinner component from react-bootstrap library in debug.jsx file (link, link)
    • Add isLoading state variable and setter function to Debug component in debug.jsx file (link)
    • Set isLoading to true before sending API request and to false after receiving response in submit function in debug.jsx file (link)
    • Add hidden attribute to Spinner component based on isLoading value in debug.jsx file (link)
    • Define custom CSS classes for styling the spinner in Debug.module.css file (link)
  • Add version information based on commit hash on debug page (link, link, link, link)
    • Add two lines to Dockerfile to export and set NEXT_PUBLIC_COMMIT_HASH environment variable (link)
    • Add version div element with NEXT_PUBLIC_COMMIT_HASH value in debug.jsx file (link)
    • Pass NEXT_PUBLIC_COMMIT_HASH value as commitHash parameter to Personal component in personal.jsx file (link)
    • Define custom CSS classes for styling the version element in Debug.module.css file (link)
  • Improve layout of parameter inputs on debug page (link, link, link)
    • Change import statement for styles module from Common.module.css to Debug.module.css in debug.jsx file (link)
    • Remove className attribute from ListGroup.Item component in debug.jsx file (link)
    • Add xs="auto" attribute to Col component wrapping the remove button in debug.jsx file (link)

@Robert27
Copy link
Member

Robert27 commented Nov 4, 2023

In my opinion, this feature is not necessary for the normal user, who has no influence on the build anyway (in contrast to App Store updates with a normal app).
It only leads to an overloaded UI with too many features, like @M4GNV5 mentioned at the Hackathon.

@Robert27 Robert27 requested a review from M4GNV5 November 4, 2023 00:24
Robert27
Robert27 previously approved these changes Nov 4, 2023
M4GNV5
M4GNV5 previously requested changes Nov 4, 2023
rogue-thi-app/pages/personal.jsx Outdated Show resolved Hide resolved
@Robert27 Robert27 requested review from Robert27 and removed request for Robert27 November 4, 2023 12:00
@BuildmodeOne
Copy link
Member Author

image

@BuildmodeOne
Copy link
Member Author

In my opinion, this feature is not necessary for the normal user, who has no influence on the build anyway (in contrast to App Store updates with a normal app). It only leads to an overloaded UI with too many features, like @M4GNV5 mentioned at the Hackathon.

The version is now moved to the debug page. I also improved the debug page a bit :)

@BuildmodeOne
Copy link
Member Author

@M4GNV5 @alexhorn @Robert27 Can somebody pls review? πŸ₯ΊπŸ‘‰πŸ‘ˆ

@BuildmodeOne BuildmodeOne dismissed M4GNV5’s stale review November 8, 2023 15:54

Changed in #f12b63d

Copy link
Member

@Robert27 Robert27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug page looks great and should be correct. But I can't say anything about the Dockerscript tho

Robert27

This comment was marked as duplicate.

@BuildmodeOne BuildmodeOne merged commit 8f2f1e3 into neuland-ingolstadt:develop Nov 9, 2023
3 checks passed
@BuildmodeOne BuildmodeOne deleted the buildversion branch November 9, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants