Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #350 #355

Closed
wants to merge 1 commit into from
Closed

bug #350 #355

wants to merge 1 commit into from

Conversation

giselaortt
Copy link

@giselaortt giselaortt commented Oct 30, 2023

πŸ€– Generated by Copilot at 0c3a892

Summary

🍽️🚫🌐

Improved allergen handling in mensa.js API. Used allergyMap to filter and translate allergen codes, and modified regex and loop to remove codes from meal text.

Sing, O Muse, of the skillful coder who improved
The extraction and display of allergens, the bane of many,
From the mensa API data, the source of daily nourishment.
He used an external allergyMap, a cunning device, to filter and translate

Walkthrough

  • Import allergyMap object from allergyMap.json to map allergen codes to names (link)
  • Update regex and loop to extract and filter allergens from meal text using allergyMap (link)

@Robert27 Robert27 requested a review from M4GNV5 October 30, 2023 12:11
Copy link
Member

@M4GNV5 M4GNV5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it hard to verify the functionality of your code, so I changed the new code into glot.io and added some tests. As of now it does not seem to work properly. The allergenes Set is empty and stuff like (Fusili) is removed too:

https://glot.io/snippets/gq4pit4fsa

@Robert27
Copy link
Member

Robert27 commented Nov 8, 2023

stale?

@Robert27 Robert27 added hackathon Will be solved during the next neuland.app Hackathon stale STALE labels Nov 8, 2023
@Robert27 Robert27 closed this Nov 30, 2023
@giselaortt giselaortt deleted the main branch December 2, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Will be solved during the next neuland.app Hackathon stale STALE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/Improve Mensa dish allergene parsing
3 participants