Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

center map for neuburg students #353

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

ElmarLienerth
Copy link
Contributor

@ElmarLienerth ElmarLienerth commented Oct 27, 2023

πŸ€– Generated by Copilot at 9ee2dc2

Summary

πŸ—ΊοΈπŸŽ“πŸŽ“

This pull request adds a feature to recenter the map based on the user's faculty in the RoomMap component, and updates the course short names data for the neuland.app website. It also enhances the useUserKind hook to return the user's faculty when they are a student, and adapts the existing components that use the hook to destructure the new object. Additionally, it fixes a typo in the date-utils module.

Sing, O Muse, of the skillful developers who wrought
Many changes to the code of the neuland app, and brought
New features and fixes to the users, who sought
To navigate the campus and the courses they were taught.

Walkthrough

  • Modify useUserKind hook to return userKind and userFaculty properties and fetch faculty from backend ()
  • Destructure userKind and userFaculty from useUserKind hook in various components and pages (link, link, link, link, link, link, link, link, link)
  • Use userFaculty to recenter the map in RoomMap component using useMap hook and Recenter component (link, link, link, link, link, link, link)
  • Fix typo in comment of getMonday function in date-utils.jsx (link)

@BuildmodeOne BuildmodeOne linked an issue Oct 27, 2023 that may be closed by this pull request
@BuildmodeOne BuildmodeOne requested a review from Robert27 October 29, 2023 22:35
rogue-thi-app/lib/hooks/user-kind.js Outdated Show resolved Hide resolved
@BuildmodeOne BuildmodeOne requested a review from Robert27 October 30, 2023 17:26
@Robert27 Robert27 merged commit a67a29b into neuland-ingolstadt:develop Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center room map to Neuburg for faculty NI students
3 participants